----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28790/#review64271 -----------------------------------------------------------
Ship it! Comments are minor. They can be addressed in followup JIRAs. ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java <https://reviews.apache.org/r/28790/#comment106905> pGraphContext doesn't seems inituitive. ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java <https://reviews.apache.org/r/28790/#comment106910> Should we just remove the line? ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java <https://reviews.apache.org/r/28790/#comment106917> Some description for this method would be good. - Xuefu Zhang On Dec. 7, 2014, 5:14 a.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28790/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2014, 5:14 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8638 > https://issues.apache.org/jira/browse/HIVE-8638 > > > Repository: hive-git > > > Description > ------- > > Implemented bucket map join optimization for spark. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 6f6518a > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java > cfc1501 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java > 2f9e55a > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HashTableLoader.java > 2fe33f5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java > 1260c83 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java > 4054173 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java > c8d0ecd > ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java > e3cab05 > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkBucketMapJoinContext.java > PRE-CREATION > ql/src/test/queries/clientpositive/bucket_map_join_spark1.q PRE-CREATION > ql/src/test/queries/clientpositive/bucket_map_join_spark2.q PRE-CREATION > ql/src/test/queries/clientpositive/bucket_map_join_spark3.q PRE-CREATION > ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/bucket_map_join_spark3.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/bucket_map_join_spark1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/bucket_map_join_spark2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/bucket_map_join_spark3.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/28790/diff/ > > > Testing > ------- > > Unit test > > > Thanks, > > Jimmy Xiang > >
