[ https://issues.apache.org/jira/browse/HIVE-9001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230871#comment-14230871 ]
Sushanth Sowmyan commented on HIVE-9001: ---------------------------------------- Looks good to me except for one minor fix - in the change to data/conf/hive-log4j.properties, you seem to have a comment section that is space-aligned to go to the next line rather than having newlines, which makes it one long comment line in the patch. I can fix this myself before committing if that's okay with you. > Ship with log4j.properties file that has a reliable time based rolling policy > ----------------------------------------------------------------------------- > > Key: HIVE-9001 > URL: https://issues.apache.org/jira/browse/HIVE-9001 > Project: Hive > Issue Type: Bug > Reporter: Hari Sankar Sivarama Subramaniyan > Assignee: Hari Sankar Sivarama Subramaniyan > Attachments: HIVE-9001.1.patch > > > The hive log gets locked by the hive process and cannot be rolled in windows > OS. > Install Hive in Windows, start hive, try and rename hive log while Hive is > running. > Wait for log4j tries to rename it and it will throw the same error as it is > locked by the process. > The changes in https://issues.apache.org/bugzilla/show_bug.cgi?id=29726 > should be integrated to Hive for a reliable rollover. -- This message was sent by Atlassian JIRA (v6.3.4#6332)