----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28403/ -----------------------------------------------------------
(Updated Nov. 28, 2014, 6:04 p.m.) Review request for hive, Ashutosh Chauhan, Prasad Mujumdar, and Szehon Ho. Changes ------- Update patch to limit the change in Hive JDBC driver. Repository: hive-git Description (updated) ------- For JDBC application using query like select * , the columnLabel in ResultSet.getXXX(String columnLabel) has to be a full-qualified name (e.g. tableName.colName) unless you set the hive.resultset.use.unique.column.names to false, but this setting will break other cases which require the qualified name (see HIVE-6687). This patch supports Hive JDBC ResultSet.getXXX(key) works for queries like following when hive.resultset.use.unique.column.names is true: a)select * from src b)select key from src c)select * from srcview d)select key from srcview. The changes in this patch include: 1. findColumn in HiveBaseResultSet will find a column either by short name or qualified name 2. Unit tests Diffs (updated) ----- itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java f2560e2e4793cca11950519708b1a666eb700e50 jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 8cbf9e7092489a2adb0bc2ba6b5ee38e41c041f8 Diff: https://reviews.apache.org/r/28403/diff/ Testing ------- 1. New test cases in TestJdbcDriver2.java passed 2. pre-committed tests were submitted Thanks, Chaoyu Tang
