[
https://issues.apache.org/jira/browse/HIVE-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104681#comment-13104681
]
jirapos...@reviews.apache.org commented on HIVE-2445:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1882/#review1893
-----------------------------------------------------------
Ship it!
- Ning
On 2011-09-14 16:53:49, Kevin Wilfong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1882/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 16:53:49)
bq.
bq.
bq. Review request for hive and Ning Zhang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I change the method called when logging pre, failure, and post hooks to
the PerfLogger to getName instead of getSimpleName.
bq.
bq.
bq. This addresses bug HIVE-2445.
bq. https://issues.apache.org/jira/browse/HIVE-2445
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1170268
bq.
bq. Diff: https://reviews.apache.org/r/1882/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran the unit test queries, and verified the intended change in the logs.
bq.
bq.
bq. Thanks,
bq.
bq. Kevin
bq.
bq.
> The PerfLogger should log the full name of hooks, not just the simple name.
> ---------------------------------------------------------------------------
>
> Key: HIVE-2445
> URL: https://issues.apache.org/jira/browse/HIVE-2445
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
>
> Sometimes the simple name of a hook is not enough to identify it, so the
> PerfLogger should log the full name instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
