----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1818/ -----------------------------------------------------------
(Updated 2011-09-13 01:39:58.571166) Review request for hive. Summary (updated) ------- Modified the ParseException message to include the actual token it fails on (When available). It should make it easier to grok the actual problem from the error. This addresses bug HIVE-198. https://issues.apache.org/jira/browse/HIVE-198 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 1164307 trunk/ql/src/test/results/clientnegative/column_rename3.q.out 1164307 trunk/ql/src/test/results/clientnegative/invalid_select_expression.q.out 1164307 trunk/ql/src/test/results/clientnegative/invalid_tbl_name.q.out 1164307 trunk/ql/src/test/results/compiler/errors/garbage.q.out 1164307 trunk/ql/src/test/results/compiler/errors/missing_overwrite.q.out 1164307 trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out 1164307 Diff: https://reviews.apache.org/r/1818/diff Testing ------- ant test -Dtestcase=TestParseNegative Thanks, avivey