[
https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102909#comment-13102909
]
jirapos...@reviews.apache.org commented on HIVE-2398:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/#review1857
-----------------------------------------------------------
Please add a testcase. Also, I tried running 'set -v' from the CLI after
setting hive.cli.print.header=true, and I don't see the column name in the
output. This seems like a bug?
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4245>
Checkstyle: static final variable names should appear in ALL CAPS
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4248>
bld? Might be good to change the name to getSchema. Also, since setColName
is a constant there's no need for this method to have an input parameter.
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4247>
Please add static imports for STRING_TYPE_NAME, SERIALIZATION_NULL_FORMAT,
and defaultNullString.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
<https://reviews.apache.org/r/1605/#comment4249>
This comment is no longer valid. Also, it might be cleaner to remove the
else clause.
- Carl
On 2011-08-19 22:37:45, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1605/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-19 22:37:45)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The Hive server currently has the framework to process the Cli commands
like 'set'. But it returns an empty schema definition for these resultsets. The
patch here is to add a getSchema() to the CommandResponse interface. The
SetProcessor is modified to build a schema object which is returned with
getSchema.
bq. HiveServer is modified to call the getSchema for command cases as well.
bq.
bq.
bq. This addresses bug HIVE-2398.
bq. https://issues.apache.org/jira/browse/HIVE-2398
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java
4f7f472
bq. ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
97fa1ab
bq. service/src/java/org/apache/hadoop/hive/service/HiveServer.java c4b041f
bq.
bq. Diff: https://reviews.apache.org/r/1605/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested with ODBC program to execute the set command. Ran Hive unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by
> ODBC or JDBC clients. But currently only the data is returned to client but
> not schema for that resultset. This makes it unusable for a ODBC or JDBC
> client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
