[
https://issues.apache.org/jira/browse/HIVE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094831#comment-13094831
]
Ning Zhang commented on HIVE-2415:
----------------------------------
Ashutosh, we are doing metastore connections in DDLSemanticAnalyzer even before
Yongqiang's patch (see DDLSemanticAnalyzer.java:1712). The extra JDO query in
DDLSemanticAnalyzer introduced in this patch is to get the columns info (in
SD), which was moved from the DDLTask.
So this patch should not introduce any extra metastore connections or network
traffic. It just moved some metastore access from execution time to compile
time, which I think is an improvement. The reason is that the error it tries to
handle is a kind of "semantic" error which should be handled in
DDLSemanticAnalyzer, rather than execution error. What do you think?
> disallow partition column names when doing replace columns
> ----------------------------------------------------------
>
> Key: HIVE-2415
> URL: https://issues.apache.org/jira/browse/HIVE-2415
> Project: Hive
> Issue Type: Bug
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2415.1.patch
>
>
> alter table replace columns allows to add a column with the same name as
> partition column, which introduced inconsistency.
> We should disallow this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
