----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1672/#review1686 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java <https://reviews.apache.org/r/1672/#comment3842> remove TAB trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java <https://reviews.apache.org/r/1672/#comment3844> tab trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java <https://reviews.apache.org/r/1672/#comment3843> tab trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java <https://reviews.apache.org/r/1672/#comment3845> does this metastore object change causes the mapped DB table change? it looks dangerous here. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java <https://reviews.apache.org/r/1672/#comment3846> why we need to clear deserializer here? Is it to make sure column names are not from deserializer? - Ning On 2011-08-28 23:14:12, Yongqiang He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1672/ > ----------------------------------------------------------- > > (Updated 2011-08-28 23:14:12) > > > Review request for hive and Ning Zhang. > > > Summary > ------- > > move validation of renaming/replacing columns from runtime to parser > > > This addresses bug HIVE-2415. > https://issues.apache.org/jira/browse/HIVE-2415 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1162190 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1162190 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1162190 > trunk/ql/src/test/queries/clientnegative/replace_columns.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/replace_columns_2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/replace_columns_3.q PRE-CREATION > trunk/ql/src/test/results/clientnegative/altern1.q.out 1162190 > trunk/ql/src/test/results/clientnegative/column_rename1.q.out 1162190 > trunk/ql/src/test/results/clientnegative/column_rename2.q.out 1162190 > trunk/ql/src/test/results/clientnegative/column_rename4.q.out 1162190 > trunk/ql/src/test/results/clientnegative/replace_columns.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/replace_columns_2.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/replace_columns_3.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/replace_columns_4.q.out > PRE-CREATION > trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1162190 > > Diff: https://reviews.apache.org/r/1672/diff > > > Testing > ------- > > > Thanks, > > Yongqiang > >
