[
https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088891#comment-13088891
]
jirapos...@reviews.apache.org commented on HIVE-2184:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1088/
-----------------------------------------------------------
(Updated 2011-08-22 18:23:44.041004)
Review request for hive and John Sichi.
Changes
-------
Fixed review comments and updated the patch.
Summary
-------
Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
This addresses bug HIVE-2184.
https://issues.apache.org/jira/browse/HIVE-2184
Diffs (updated)
-----
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1154844
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1154844
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1154844
Diff: https://reviews.apache.org/r/1088/diff
Testing
-------
Ran all the testcases
Thanks,
chinna
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise
> Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.2.patch,
> HIVE-2184.3.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the
> variable "standAloneClient" is never become true then client.shutdown() never
> call.
> 2)Hive.close() After calling metaStoreClient.close() need to make
> metaStoreClient=null
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
