[
https://issues.apache.org/jira/browse/HIVE-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088096#comment-13088096
]
jirapos...@reviews.apache.org commented on HIVE-1953:
-----------------------------------------------------
bq. On 2011-08-19 21:08:09, Charles Chen wrote:
bq. > Currently if you type something like
bq. >
bq. > EXPLAIN SELECT "abcd
bq. > --
bq. > efgh" as field from invites;
bq. >
bq. > the string "abcd\n--\nefgh"with the newlines is accepted--this diff
removes the line with the "--" which seems incorrect.
Good point. Similarly, if you try something like EXPLAIN SELECT "abcd;
it fails right now because the cliDriver tokenizes end of statements on
semi-colons. The problem here is that cliDriver only partially tokenizes the
input before passing it to the Driver which tokenizes things correctly. There
is a workaround here which is to add a recognized escape before the --, but
that should not be necessary.
- Syed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1587/#review1564
-----------------------------------------------------------
On 2011-08-19 08:10:32, Syed Albiz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-19 08:10:32)
bq.
bq.
bq. Review request for hive and Yongqiang He.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. skip comments in cliDriver.main() instead of passing down to command
processors.
bq.
bq.
bq. This addresses bug HIVE-1953.
bq. https://issues.apache.org/jira/browse/HIVE-1953
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5
bq.
bq. Diff: https://reviews.apache.org/r/1587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. tested build, since the test suite goes through driver, adding a query
file test case did not work.
bq.
bq.
bq. Thanks,
bq.
bq. Syed
bq.
bq.
> Hive should process comments in CliDriver
> -----------------------------------------
>
> Key: HIVE-1953
> URL: https://issues.apache.org/jira/browse/HIVE-1953
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: Syed S. Albiz
> Attachments: HIVE-1953.1.patch
>
>
> If you put commend before a set command, it will faile.
> Like this:
> -- TestSerDe is a user defined serde where the default delimiter is Ctrl-B
> -- the user is overwriting it with ctrlC
> set hive.input.format=org.apache.hadoop.hive.ql.io.HiveInputFormat;
> Hive should process the comment in CliDriver, and ignore the comment right
> away, instead of passing it to the downstream processors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
