----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1587/#review1564 -----------------------------------------------------------
Currently if you type something like EXPLAIN SELECT "abcd -- efgh" as field from invites; the string "abcd\n--\nefgh"with the newlines is accepted--this diff removes the line with the "--" which seems incorrect. - Charles On 2011-08-19 08:10:32, Syed Albiz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1587/ > ----------------------------------------------------------- > > (Updated 2011-08-19 08:10:32) > > > Review request for hive and Yongqiang He. > > > Summary > ------- > > skip comments in cliDriver.main() instead of passing down to command > processors. > > > This addresses bug HIVE-1953. > https://issues.apache.org/jira/browse/HIVE-1953 > > > Diffs > ----- > > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5 > > Diff: https://reviews.apache.org/r/1587/diff > > > Testing > ------- > > tested build, since the test suite goes through driver, adding a query file > test case did not work. > > > Thanks, > > Syed > >
