[
https://issues.apache.org/jira/browse/HIVE-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087939#comment-13087939
]
jirapos...@reviews.apache.org commented on HIVE-2354:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1456/
-----------------------------------------------------------
(Updated 2011-08-19 20:20:22.217903)
Review request for hive, Yongqiang He, John Sichi, and Ning Zhang.
Changes
-------
Moves a bunch of the logic to update index timestamps into the AlterIndex
DDLTask rather than the DDLSemanticAnalyzer, so that the timestamp is
guaranteed to be updated *after* the base table is touched. This change is
reflected in index_auto_update.q, as now we see that the check for index
staleness in the SELECT passes and we use the index in index_auto_update.q as
desired.
Summary
-------
Chain a second set of tasks to the MoveTask for INSERT statements.
This addresses bug HIVE-2354.
https://issues.apache.org/jira/browse/HIVE-2354
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 815f15a
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c031f40
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java c17891c
ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 6f311c6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cb7a542
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java f0dfd00
ql/src/test/queries/clientpositive/index_auto_update.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_update.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_stale.q.out 24900a1
Diff: https://reviews.apache.org/r/1456/diff
Testing
-------
Added testcase "index_auto_update.q"
Thanks,
Syed
> Support automatic rebuilding of indexes when they go stale
> ----------------------------------------------------------
>
> Key: HIVE-2354
> URL: https://issues.apache.org/jira/browse/HIVE-2354
> Project: Hive
> Issue Type: Improvement
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2354.1.patch, HIVE-2354.2.patch, HIVE-2354.3.patch,
> HIVE-2354.4.patch, HIVE-2354.5.patch, HIVE-2354.6.patch
>
>
> Support a mode where indexes will be automatically rebuilt when the
> table/partition they are based on is modified. So if index foo is built on
> table bar, and bar has it's contents overwritten, we should support a mode
> where index foo will automatically rebuild itself.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
