----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1515/#review1503 -----------------------------------------------------------
Log.WARN is not sufficient to print error message to console. There is another place you can add the check in compile time: ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java in DefaultExprProcessor.getFuncExprNodeDesc(). There you can safely get error output stream from SessionState.get(). - Siying On 2011-08-15 23:37:16, Kevin Wilfong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1515/ > ----------------------------------------------------------- > > (Updated 2011-08-15 23:37:16) > > > Review request for hive and Siying Dong. > > > Summary > ------- > > I added a check in the code for equality expressions (includes inequalities) > with operands of different types, that throws an error or logs a warning, > depending on strict mode, if one operand is a string or double and the other > is a bigint. > > > This addresses bug HIVE-2378. > https://issues.apache.org/jira/browse/HIVE-2378 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1157946 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java > 1157946 > trunk/ql/src/test/queries/clientnegative/compare_double_bigint.q > PRE-CREATION > trunk/ql/src/test/queries/clientnegative/compare_string_bigint.q > PRE-CREATION > trunk/ql/src/test/results/clientnegative/compare_double_bigint.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/compare_string_bigint.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/1515/diff > > > Testing > ------- > > I added two tests (one for strings and one for doubles) to record the issue. > > I also verified the unit tests still run. > > > Thanks, > > Kevin > >
