[
https://issues.apache.org/jira/browse/HIVE-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086293#comment-13086293
]
jirapos...@reviews.apache.org commented on HIVE-2181:
-----------------------------------------------------
bq. On 2011-08-13 14:08:14, M IS wrote:
bq. > trunk/data/conf/hive-site.xml, line 181
bq. > <https://reviews.apache.org/r/1481/diff/1/?file=32387#file32387line181>
bq. >
bq. > This overrides the value set in hive-default.xml. And also deviates
from the existing behavior. So, the property needn't be mentioned in
hive-site.xml
This is added for the testing purpose. Now it is removed.
bq. On 2011-08-13 14:08:14, M IS wrote:
bq. > trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java,
line 713
bq. > <https://reviews.apache.org/r/1481/diff/1/?file=32388#file32388line713>
bq. >
bq. > Why create a reference, when the same can be logged directly and
easily readable as well.
Creating a reference for the log message is removed
bq. On 2011-08-13 14:08:14, M IS wrote:
bq. >
trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java, line
394
bq. > <https://reviews.apache.org/r/1481/diff/1/?file=32389#file32389line394>
bq. >
bq. > There needs to be a test case to test the other use-case also, where
the user would have chosen not to set the property to "true".
Added a testcase for other user-case (Test should not clear scratchDir)
- chinna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1481/#review1444
-----------------------------------------------------------
On 2011-08-12 19:10:40, chinna wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1481/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-12 19:10:40)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Now queries leaves the map outputs under scratch.dir after execution. If
the hive server is stopped we need not keep the stopped server's map oputputs.
So whle starting the server we can clear the scratch.dir. This can help in
improved disk usage.
bq.
bq. Implemented a cleanup method in HiveServer and it will trigger based on
the property value "hive.start.cleanup.scrachdir"
bq.
bq.
bq. This addresses bug HIVE-2181.
bq. https://issues.apache.org/jira/browse/HIVE-2181
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1156493
bq. trunk/conf/hive-default.xml 1156493
bq. trunk/data/conf/hive-site.xml 1156493
bq. trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java
1156493
bq.
trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java
1156493
bq.
bq. Diff: https://reviews.apache.org/r/1481/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added test case for this scenario.
bq.
bq.
bq. Thanks,
bq.
bq. chinna
bq.
bq.
> Clean up the scratch.dir (tmp/hive-root) while restarting Hive server.
> ------------------------------------------------------------------------
>
> Key: HIVE-2181
> URL: https://issues.apache.org/jira/browse/HIVE-2181
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.8.0
> Environment: Suse linux, Hadoop 20.1, Hive 0.8
> Reporter: sanoj mathew
> Assignee: Chinna Rao Lalam
> Priority: Minor
> Attachments: HIVE-2181.1.patch, HIVE-2181.2.patch, HIVE-2181.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Now queries leaves the map outputs under scratch.dir after execution. If the
> hive server is stopped we need not keep the stopped server's map oputputs. So
> whle starting the server we can clear the scratch.dir. This can help in
> improved disk usage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
