[
https://issues.apache.org/jira/browse/HIVE-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084943#comment-13084943
]
jirapos...@reviews.apache.org commented on HIVE-2020:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1324/#review1450
-----------------------------------------------------------
* The patch does not compile. Looks like it's missing the definition for the
Substitution class. Why is this new class necessary? Why not build any new
functionality into the VariableSubstitution class?
* This patch needs to add new testcases for the namespace prefixing.
* Why is the new namespace named "define"? If not "hivevar", can we at least
use a noun instead of a verb?
- Carl
On 2011-08-08 22:44:45, Vaibhav Aggarwal wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1324/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-08 22:44:45)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Create a separate namespace for Hive variables.
bq.
bq. Added support for:
bq.
bq. 1. -d and --define;
bq. 2. set define:var=var_value; // To set the variable
bq. 3. set -v;
bq. 4. set define:var; // To print the variable
bq.
bq. Thanks
bq. Vaibhav
bq.
bq.
bq. This addresses bug HIVE-2020.
bq. https://issues.apache.org/jira/browse/HIVE-2020
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5
bq. cli/src/java/org/apache/hadoop/hive/cli/OptionsProcessor.java 90084ed
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/VariableSubstitution.java
e203dda
bq. ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
97fa1ab
bq. ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6a6e8e8
bq.
bq. Diff: https://reviews.apache.org/r/1324/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Vaibhav
bq.
bq.
> Create a separate namespace for Hive variables
> ----------------------------------------------
>
> Key: HIVE-2020
> URL: https://issues.apache.org/jira/browse/HIVE-2020
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2020-2.patch, HIVE-2020.patch
>
>
> Support for variable substitution was added in HIVE-1096. However, variable
> substitution was implemented by reusing the HiveConf namespace, so there is
> no separation between Hive configuration properties and Hive variables.
> This ticket encompasses the following enhancements:
> * Create a separate namespace for managing Hive variables.
> * Add support for setting variables on the command line via '-hivevar x=y'
> * Add support for setting variables through the CLI via 'var x=y'
> * Add support for referencing variables in statements using either
> '${hivevar:var_name}' or '${var_name}'
> * Provide a means for differentiating between hiveconf, hivevar, system, and
> environment properties in the output of 'set -v'
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
