[
https://issues.apache.org/jira/browse/HIVE-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084624#comment-13084624
]
jirapos...@reviews.apache.org commented on HIVE-2156:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/777/#review1445
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/777/#comment3345>
assert(jobId.equals(ti.getJobId())) would have been enough
ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
<https://reviews.apache.org/r/777/#comment3346>
Please take the declaration out of the loop
ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
<https://reviews.apache.org/r/777/#comment3347>
the condition could have been much simpler this way:
jobId.equals(ti.getJobId())
ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
<https://reviews.apache.org/r/777/#comment3348>
invoking size() directly on the failures map would have been enough
ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
<https://reviews.apache.org/r/777/#comment3350>
Please use java.util.Collections.max() inplace of the existing logic.
ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
<https://reviews.apache.org/r/777/#comment3349>
Please use entry set to loop over the failures map, instead of using the
keyset
- M
On 2011-08-11 01:07:35, Syed Albiz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/777/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-11 01:07:35)
bq.
bq.
bq. Review request for hive and John Sichi.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. - Add local error messages to point to job logs and provide TaskIDs
bq. - Add a timeout to the fetching of task logs and errors
bq.
bq.
bq. This addresses bug HIVE-2156.
bq. https://issues.apache.org/jira/browse/HIVE-2156
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. build-common.xml 4856c5f
bq. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f
bq. conf/hive-default.xml 3a4f833
bq. contrib/src/test/results/clientnegative/case_with_row_sequence.q.out
4447c65
bq. ql/build.xml 449b47a
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
1c6f092
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java PRE-CREATION
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java e687b1a
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java 3d5e95d
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
cec0d46
bq. ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 8a50dc6
bq. ql/src/test/queries/clientnegative/minimr_broken_pipe.q PRE-CREATION
bq. ql/src/test/results/clientnegative/dyn_part3.q.out 5f4df65
bq. ql/src/test/results/clientnegative/index_compact_entry_limit.q.out
06437c7
bq. ql/src/test/results/clientnegative/index_compact_size_limit.q.out
54f1262
bq. ql/src/test/results/clientnegative/minimr_broken_pipe.q.out PRE-CREATION
bq. ql/src/test/results/clientnegative/script_broken_pipe1.q.out d33d2cc
bq. ql/src/test/results/clientnegative/script_broken_pipe2.q.out afbaa44
bq. ql/src/test/results/clientnegative/script_broken_pipe3.q.out fe8f757
bq. ql/src/test/results/clientnegative/script_error.q.out c72d780
bq. ql/src/test/results/clientnegative/udf_reflect_neg.q.out f2082a3
bq. ql/src/test/results/clientnegative/udf_test_error.q.out 5fd9a00
bq. ql/src/test/results/clientnegative/udf_test_error_reduce.q.out ddc5e5b
bq. ql/src/test/results/clientpositive/auto_join25.q.out 362b2fa
bq. ql/src/test/results/clientpositive/mapjoin_hook.q.out acdeefa
bq. ql/src/test/templates/TestNegativeCliDriver.vm ec13f79
bq.
bq. Diff: https://reviews.apache.org/r/777/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested TestNegativeCliDriver in both local and miniMR mode
bq.
bq.
bq. Thanks,
bq.
bq. Syed
bq.
bq.
> Improve error messages emitted during task execution
> ----------------------------------------------------
>
> Key: HIVE-2156
> URL: https://issues.apache.org/jira/browse/HIVE-2156
> Project: Hive
> Issue Type: Improvement
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Fix For: 0.8.0
>
> Attachments: HIVE-2156.1.patch, HIVE-2156.10.patch,
> HIVE-2156.11.patch, HIVE-2156.12.patch, HIVE-2156.13.patch,
> HIVE-2156.2.patch, HIVE-2156.4.patch, HIVE-2156.8.patch, HIVE-2156.9.patch
>
>
> Follow-up to HIVE-1731
> A number of issues were related to reporting errors from task execution and
> surfacing these in a more useful form.
> Currently a cryptic message with "Execution Error" and a return code and
> class name of the task is emitted.
> The most useful log messages here are emitted to the local logs, which can be
> found through jobtracker. Having either a pointer to these logs as part of
> the error message or the actual content would improve the usefulness
> substantially. It may also warrant looking into how the underlying error
> reporting through Hadoop is done and if more information can be propagated up
> from there.
> Specific issues raised in HIVE-1731:
> FAILED: Execution Error, return code 2 from
> org.apache.hadoop.hive.ql.exec.MapRedTask
> * issue was in regexp_extract syntax
> FAILED: Execution Error, return code 1 from
> org.apache.hadoop.hive.ql.exec.DDLTask
> * tried: desc table_does_not_exist;
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
