-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1441/
-----------------------------------------------------------
(Updated 2011-08-10 00:56:44.290697)
Review request for hive and Ning Zhang.
Changes
-------
Added hive.autogen.columnname.prefix.label and
hive.autogen.columnname.prefix.includefuncname to hive-default.xml
Created a static final variable for the 20 char length limit in
SemanticAnalyzer.java
Took out default variable values from SemanticAnalyzer.java (will be set in
constructor)
Fixed checkstyle line length warnings introduced by patch in HiveConf.java,
SemanticAnalyzer.java
Added some more comments in SemanticAnalyzer.java
Summary
-------
Default behavior will be as before.
Adding new Hive conf vars to make the column names include the aggregation
function and params.
This addresses bug HIVE-1916.
https://issues.apache.org/jira/browse/HIVE-1916
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155181
trunk/conf/hive-default.xml 1155181
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1155181
trunk/ql/src/test/queries/clientpositive/autogen_colname.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/autogen_colname.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1441/diff
Testing
-------
Added new query file with expected results. All unit tests pass
Thanks,
sameerm
