[
https://issues.apache.org/jira/browse/HIVE-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082014#comment-13082014
]
jirapos...@reviews.apache.org commented on HIVE-2364:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1443/
-----------------------------------------------------------
Review request for hive and Ning Zhang.
Summary
-------
I created a new class PerfLogger, which wraps the old functionality of
Utilities' PerfLogBegin and PerfLogBegin methods. I also added a config
variable hive.exec.perf.logger. The value of this variable can be changed to
point to a subclass of PerfLogger which can customize the code in PerfLogBegin
and PerfLogEnd.
This addresses bug HIVE-2364.
https://issues.apache.org/jira/browse/HIVE-2364
Diffs
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155439
trunk/conf/hive-default.xml 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
1155439
Diff: https://reviews.apache.org/r/1443/diff
Testing
-------
I ran the code as it is and made sure it continued to log the performance
messages as before.
I also created a subclass of PerfLogger and used its class name as the value of
hive.exec.perf.logger, and verified the subclass's code was run.
Thanks,
Kevin
> Make performance logging configurable.
> --------------------------------------
>
> Key: HIVE-2364
> URL: https://issues.apache.org/jira/browse/HIVE-2364
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2364.1.patch.txt
>
>
> Currently, the way we measure the length of time spent by a piece of code is
> using the methods PerfLogBegin and PerfLogEnd in the Utilities class. If we
> made the class responsible for logging this data configurable, it would allow
> for more flexibility, in particular, we would not be restricted to logging to
> an Apache Commons Log.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
