----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1256/#review1288 -----------------------------------------------------------
Ship it! +1. Will commit if tests pass. - Carl On 2011-08-03 04:45:10, Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1256/ > ----------------------------------------------------------- > > (Updated 2011-08-03 04:45:10) > > > Review request for hive and Carl Steinbach. > > > Summary > ------- > > Changes from last patch: > > Re-based to trunk. > Removed assert not null statements for list and map. > Updated explode_null.q to test NULL values for map also. > > > This addresses bug HIVE-1735. > https://issues.apache.org/jira/browse/HIVE-1735 > > > Diffs > ----- > > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFExplode.java > 1151047 > trunk/ql/src/test/queries/clientnegative/udtf_explode_not_supported1.q > PRE-CREATION > trunk/ql/src/test/queries/clientnegative/udtf_explode_not_supported2.q > PRE-CREATION > trunk/ql/src/test/queries/clientnegative/udtf_explode_not_supported3.q > PRE-CREATION > trunk/ql/src/test/queries/clientnegative/udtf_explode_not_supported4.q > PRE-CREATION > trunk/ql/src/test/queries/clientpositive/explode_null.q 1151047 > trunk/ql/src/test/queries/clientpositive/udf_explode.q 1151047 > trunk/ql/src/test/queries/clientpositive/udtf_explode.q 1151047 > trunk/ql/src/test/results/clientnegative/udtf_explode_not_supported1.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/udtf_explode_not_supported2.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/udtf_explode_not_supported3.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/udtf_explode_not_supported4.q.out > PRE-CREATION > trunk/ql/src/test/results/clientpositive/explode_null.q.out 1151047 > trunk/ql/src/test/results/clientpositive/udf_explode.q.out 1151047 > trunk/ql/src/test/results/clientpositive/udtf_explode.q.out 1151047 > > Diff: https://reviews.apache.org/r/1256/diff > > > Testing > ------- > > All tests passed with the patch. > > > Thanks, > > Amareshwari > >
