[
https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079136#comment-13079136
]
jirapos...@reviews.apache.org commented on HIVE-2171:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/790/
-----------------------------------------------------------
(Updated 2011-08-04 00:12:21.542815)
Review request for hive.
Changes
-------
Updated patch based on review comments.
Summary
-------
HIVE-2171: Allow custom serdes to set field comments
This addresses bug HIVE-2171.
https://issues.apache.org/jira/browse/HIVE-2171
Diffs (updated)
-----
ivy/libraries.properties af856bd
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
c1fa4e5
serde/ivy.xml d6c836a
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
4850601
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
e2fa9db
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java
2947e49
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java
3d5408f
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java
881c3c1
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java
bd42a0c
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
0c8cc42
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
4a934c5
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java
3b26e45
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java
62c3017
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java
76ff736
serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
f139ea5
Diff: https://reviews.apache.org/r/790/diff
Testing
-------
New unit test and refactor existing unit test.
Thanks,
Jakob
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set
> its comment. These are set in the metastore utils to {{(from
> deserializer)}}. For those serdes that can provide meaningful comments for a
> field, they should be propagated to the table description. These
> serde-provided comments could be prepended to "(from deserializer)" if others
> feel that's a meaningful distinction. This change involves updating
> {{StructField}} to support a (possibly null) comment field and then
> propagating this change out to the myriad places {{StructField}} is thrown
> around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
