----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1259/#review1278 -----------------------------------------------------------
trunk/data/conf/hive-site.xml <https://reviews.apache.org/r/1259/#comment2921> Why is a hook needed to update this count? trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/1259/#comment2924> One possible issue is that if the user changes the value of this through the CLI (i.e. with a set xxx=yyy;), it wouldn't take effect. It should be read in the constructor or in the methods. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/1259/#comment2923> Should be info or debug, not error trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/1259/#comment2927> Why are we saving unboundKey? Can we just break on the first instance when partSpec does not contain fs.getName()? trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/1259/#comment2928> Typo trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/1259/#comment2929> Change to something like 'Cannot drop a subset of partitions in an archive' trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/1259/#comment2930> This is going to be feature that we'll need to support. The script that drops based on retention can't unarchive as it will take too long. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MetaUtils.java <https://reviews.apache.org/r/1259/#comment2931> Need more context for these log messages - i.e. what kind of partitions were found? trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MetaUtils.java <https://reviews.apache.org/r/1259/#comment2934> The max parameter for getPartitions is not yet implemented. It needs to be or otherwise this will hang for large tables. trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateArchivedCounter.java <https://reviews.apache.org/r/1259/#comment2919> Comment from a different hook? trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateArchivedCounter.java <https://reviews.apache.org/r/1259/#comment2920> Formatting - add spaces trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/1259/#comment2932> More context trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/1259/#comment2933> Remove commented code - Paul On 2011-08-02 21:34:07, Marcin Kurczych wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1259/ > ----------------------------------------------------------- > > (Updated 2011-08-02 21:34:07) > > > Review request for hive, Paul Yang and namit jain. > > > Summary > ------- > > Allowing archiving at chosen level. When table is partitioned by ds, hr, min > it allows archiving at ds level, hr level and min level. Corresponding > syntaxes are: > ALTER TABLE test ARCHIVE PARTITION (ds='2008-04-08'); > ALTER TABLE test ARCHIVE PARTITION (ds='2008-04-08', hr='11'); > ALTER TABLE test ARCHIVE PARTITION (ds='2008-04-08', hr='11', min='30'); > > You cannot do much to archived partitions. You can read them. You cannot > write to them / overwrite them. You can drop single archived partitions, but > not parts of bigger archives. > > > Diffs > ----- > > trunk/data/conf/hive-site.xml 1153271 > trunk/metastore/if/hive_metastore.thrift 1153271 > trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h 1153271 > trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp 1153271 > > trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java > 1153271 > > trunk/metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php > 1153271 > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/constants.py 1153271 > trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb 1153271 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MetaUtils.java > PRE-CREATION > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1153271 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateArchivedCounter.java > PRE-CREATION > > trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java > 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1153271 > trunk/ql/src/test/queries/clientnegative/archive_insert1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert3.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert4.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi3.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi4.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi5.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi6.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi7.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec3.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/archive_corrupt.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/archive_multi.q PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive1.q.out 1153271 > trunk/ql/src/test/results/clientnegative/archive2.q.out 1153271 > trunk/ql/src/test/results/clientnegative/archive_insert1.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert2.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert3.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert4.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi1.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi2.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi3.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi4.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi5.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi6.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi7.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec1.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec2.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out > PRE-CREATION > trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/archive_multi.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/1259/diff > > > Testing > ------- > > Added unittests for normal uses. > Tried recovery during manual tests (had to simulate exceptions in different > places in code, which shouldn't be committed, that's why it had to be manual > testing). > > > Thanks, > > Marcin > >
