----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/790/#review1274 -----------------------------------------------------------
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java <https://reviews.apache.org/r/790/#comment2908> Use curly brackets for all if statements (even when the body only has one line). Use ant checkstyle to find more of these. - John On 2011-05-26 20:16:20, Jakob Homan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/790/ > ----------------------------------------------------------- > > (Updated 2011-05-26 20:16:20) > > > Review request for hive. > > > Summary > ------- > > HIVE-2171: Allow custom serdes to set field comments > > > This addresses bug HIVE-2171. > https://issues.apache.org/jira/browse/HIVE-2171 > > > Diffs > ----- > > ivy/libraries.properties af856bd > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > c1fa4e5 > serde/ivy.xml d6c836a > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java > 4850601 > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java > e2fa9db > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java > 2947e49 > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java > 3d5408f > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java > 66f4f8d > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java > bd42a0c > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java > 90561a1 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java > 4a934c5 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java > 3b26e45 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java > 62c3017 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java > 76ff736 > > serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java > PRE-CREATION > > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java > f139ea5 > > Diff: https://reviews.apache.org/r/790/diff > > > Testing > ------- > > New unit test and refactor existing unit test. > > > Thanks, > > Jakob > >
