-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1226/
-----------------------------------------------------------
Review request for hive and Carl Steinbach.
Summary
-------
This patch addresses the specified methods based on my reading of the spec.
It's not at all clear to me that I've interpreted the spec correctly, so please
do chime in if you think something is wrong - for example: in my update Hive
string columns have a size of Integer.MAX_VALUE given Hive has no bounds on
length. Also take a look at precision and size for float/double.
This patch also fixes a problem with the metadata returned by
DatabaseMetaData.getColumns(...).getMetaData()
This addresses bug HIVE-1631.
https://issues.apache.org/jira/browse/HIVE-1631
Diffs
-----
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java 0e106be
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java cf651b6
jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 9182744
jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java PRE-CREATION
jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 91af351
Diff: https://reviews.apache.org/r/1226/diff
Testing
-------
I updated the tests and also viewed the result of these changes via Squirrel
Thanks,
Patrick
