----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/#review1215 -----------------------------------------------------------
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java <https://reviews.apache.org/r/1213/#comment2712> Actually, we can't allow for a different ordering because that would imply a different directory structure. We should just make sure that everything but the comments are equal. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java <https://reviews.apache.org/r/1213/#comment2713> Message should say - it was able to change when it shouldn't have? - Paul On 2011-07-28 07:06:24, Sohan Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1213/ > ----------------------------------------------------------- > > (Updated 2011-07-28 07:06:24) > > > Review request for hive and Paul Yang. > > > Summary > ------- > > Altering a table's partition key comments raises an > InvalidOperationException. The partition key name and type should not be > mutable, but the comment should be able to get changed. > > > This addresses bug HIVE-2319. > https://issues.apache.org/jira/browse/HIVE-2319 > > > Diffs > ----- > > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 1151219 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 1151219 > > Diff: https://reviews.apache.org/r/1213/diff > > > Testing > ------- > > Added some test cases to HiveMetaStore that pass. > > > Thanks, > > Sohan > >
