-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1137/
-----------------------------------------------------------
(Updated 2011-07-19 17:37:34.434426)
Review request for hive, John Sichi and Ning Zhang.
Changes
-------
Add a set of helpers to save/restore query specific session state. As far as I
know, there isn't really anything else command specific that needs to be done.
The other change here is to add the resetTaskIds flag = false which I think
should have been the case all along if we wanted these queries to be properly
re-entrant. I guess in the case of ALTER INDEX, where nesting was not a big
issue this was less likely to break?
Summary
-------
Save the original HiveOperation/commandType when we generate the index builder
task and restore it after we're done generating the task so that the
authorization checks make the right decision when deciding what to do.
This addresses bug HIVE-2286.
https://issues.apache.org/jira/browse/HIVE-2286
Diffs (updated)
-----
ql/src/test/results/clientpositive/index_bitmap.q.out 8f41ce3
ql/src/test/results/clientpositive/index_auto_unused.q.out 8fe3ac9
ql/src/test/results/clientpositive/index_auto_multiple.q.out 28add9f
ql/src/test/results/clientpositive/index_auto_partitioned.q.out b332a8b
ql/src/test/results/clientpositive/index_auto_file_format.q.out 8430296
ql/src/test/results/clientpositive/index_auto.q.out 222db34
ql/src/test/results/clientpositive/index_auth.q.out PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/Driver.java b278ffe
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java
61bbbf5
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
7c91946
ql/src/test/queries/clientpositive/index_auth.q PRE-CREATION
ql/src/test/results/clientnegative/index_compact_entry_limit.q.out fcb2673
ql/src/test/results/clientnegative/index_compact_size_limit.q.out fcb2673
ql/src/test/results/clientpositive/index_bitmap1.q.out 9f638f5
ql/src/test/results/clientpositive/index_bitmap2.q.out e901477
ql/src/test/results/clientpositive/index_bitmap3.q.out 8091359
ql/src/test/results/clientpositive/index_bitmap_auto.q.out e73877a
ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out
4c9efd1
ql/src/test/results/clientpositive/index_bitmap_rc.q.out 9bd3c98
ql/src/test/results/clientpositive/index_compact.q.out c339ec9
ql/src/test/results/clientpositive/index_compact_1.q.out 34ba3ca
ql/src/test/results/clientpositive/index_compact_2.q.out e8ce238
ql/src/test/results/clientpositive/index_compact_3.q.out d39556d
ql/src/test/results/clientpositive/index_creation.q.out 532f07e
Diff: https://reviews.apache.org/r/1137/diff
Testing
-------
Added new testcase to TestCliDriver: index_auth.q
Thanks,
Syed
