[
https://issues.apache.org/jira/browse/HIVE-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067418#comment-13067418
]
jirapos...@reviews.apache.org commented on HIVE-2286:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1137/#review1107
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java
<https://reviews.apache.org/r/1137/#comment2246>
Two comments on this fix:
1) I think we need a helper method, since we've started using
Driver.compile for reentrant SQL in a few places (there's actually another call
both here and in CompactIndexHandler, and one more in DDLSemanticAnalyzer).
2) While we're at it, we can make the helper method save/restore any other
statement-specific state (command string?).
- John
On 2011-07-15 22:33:48, Syed Albiz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1137/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-15 22:33:48)
bq.
bq.
bq. Review request for hive, John Sichi and Ning Zhang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Save the original HiveOperation/commandType when we generate the index
builder task and restore it after we're done generating the task so that the
authorization checks make the right decision when deciding what to do.
bq.
bq.
bq. This addresses bug HIVE-2286.
bq. https://issues.apache.org/jira/browse/HIVE-2286
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/test/results/clientpositive/index_auth.q.out PRE-CREATION
bq.
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java
61bbbf5
bq.
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
7c91946
bq. ql/src/test/queries/clientpositive/index_auth.q PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1137/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added new testcase to TestCliDriver: index_auth.q
bq.
bq.
bq. Thanks,
bq.
bq. Syed
bq.
bq.
> ClassCastException when building index with security.authorization turned on
> ----------------------------------------------------------------------------
>
> Key: HIVE-2286
> URL: https://issues.apache.org/jira/browse/HIVE-2286
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2286.1.patch
>
>
> When trying to build an index with authorization checks turned on, hive
> issues the following ClassCastException:
> org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer cannot be cast to
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzer
> at
> org.apache.hadoop.hive.ql.Driver.doAuthorization(Driver.java:540)
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:431)
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:335)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:848)
> at
> org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:224)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:358)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:293)
> at
> org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:385)
> at
> org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:392)
> at
> org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:567)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.jav
> a:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessor
> Impl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:156)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
