----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1088/#review1099 -----------------------------------------------------------
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java <https://reviews.apache.org/r/1088/#comment2230> We should get rid of the member variable standAloneClient too since it is part of the dead code. Now that we'll start calling shutdown (which we were skipping before), what will be the effect? - John On 2011-07-12 14:06:28, chinna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1088/ > ----------------------------------------------------------- > > (Updated 2011-07-12 14:06:28) > > > Review request for hive and John Sichi. > > > Summary > ------- > > Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close() > > > This addresses bug HIVE-2184. > https://issues.apache.org/jira/browse/HIVE-2184 > > > Diffs > ----- > > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 1144190 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1144190 > > Diff: https://reviews.apache.org/r/1088/diff > > > Testing > ------- > > Ran all the testcases > > > Thanks, > > chinna > >
