----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1098/ -----------------------------------------------------------
Review request for hive and John Sichi. Summary ------- There are couple of resource leaks. For example, In CliDriver.java, Method :- processReader() the buffered reader is not closed. Also there are risk(s) of resource(s) getting leaked , in such cases refactored the code to move closing of resources in finally block. This addresses bug HIVE-1884. https://issues.apache.org/jira/browse/HIVE-1884 Diffs ----- trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1145950 trunk/contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesWritableInput.java 1145950 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145950 trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFileInputFormat.java 1145950 Diff: https://reviews.apache.org/r/1098/diff Testing ------- All unit tests passed Thanks, chinna