----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/#review1039 -----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/1057/#comment2112> indentation? http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q <https://reviews.apache.org/r/1057/#comment2115> Can you include a testcase for a partitioned view? I don't see a codepath for that (we agreed the new table should come out with the same partition columns as the view). Also add a testcase for create externa table like base_table since you fixed a bug in that existing codepath. You can put that in create_like.q since it doesn't have anything to do with views. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q <https://reviews.apache.org/r/1057/#comment2116> Add order by on these queries for determinism. - John On 2011-07-11 22:06:40, Charles Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1057/ > ----------------------------------------------------------- > > (Updated 2011-07-11 22:06:40) > > > Review request for hive. > > > Summary > ------- > > https://issues.apache.org/jira/browse/HIVE-1218 > > > This addresses bug HIVE-1218. > https://issues.apache.org/jira/browse/HIVE-1218 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 1145292 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java > 1145292 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1145292 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java > 1145292 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/1057/diff > > > Testing > ------- > > > Thanks, > > Charles > >
