-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1094/
-----------------------------------------------------------

Review request for hive and Ning Zhang.


Summary
-------

Add defensive checks on operator stack when constructing the error
  message for invalid aggregate expressions (Expression not in GROUP
  BY...)


This addresses bug HIVE-2281.
    https://issues.apache.org/jira/browse/HIVE-2281


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java dfadb9f 
  ql/src/test/queries/clientnegative/nonkey_groupby.q PRE-CREATION 
  ql/src/test/results/clientnegative/nonkey_groupby.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1094/diff


Testing
-------

Added new unit test (nonkey_groupby.q) to NegativeCliDriver suite,
  made sure no breakage to existing tests covering this message:
  groupby_key.q,notable_alias3.q (TestNegativeCliDriver)
  nonkey_groupby.q,unknown_column6.q (TestNegativeParseDriver)


Thanks,

Syed

Reply via email to