----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1031/ -----------------------------------------------------------
Review request for hive. Summary ------- In the CLI, if a user inputs an incorrect column name, we currently just print the bad column name in the query. Typically, the user needs to "describe" the table to figure out the correct column. This patch prints out a list of valid column and partition names in the table when a user inputs an incorrect column name. e.g., Error in semantic analysis: Invalid table alias or column reference 'col_does_not_exist' (possible column names are: col1, col2) This addresses bug HIVE-2256. https://issues.apache.org/jira/browse/HIVE-2256 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 1140399 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1140399 trunk/ql/src/test/results/clientnegative/clustern4.q.out 1140399 trunk/ql/src/test/results/clientnegative/input2.q.out 1140399 trunk/ql/src/test/results/clientnegative/regex_col_groupby.q.out 1140399 trunk/ql/src/test/results/clientnegative/semijoin1.q.out 1140399 trunk/ql/src/test/results/clientnegative/semijoin2.q.out 1140399 trunk/ql/src/test/results/clientnegative/semijoin3.q.out 1140399 trunk/ql/src/test/results/clientnegative/semijoin4.q.out 1140399 trunk/ql/src/test/results/compiler/errors/unknown_column4.q.out 1140399 trunk/ql/src/test/results/compiler/errors/unknown_column5.q.out 1140399 Diff: https://reviews.apache.org/r/1031/diff Testing ------- Checked the outputs of relevant unit tests, and they looks good. Thanks, Sohan