> On 2011-06-27 22:47:07, Paul Yang wrote: > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java, > > lines 142-144 > > <https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line142> > > > > Can we check for equality between origP and the old partition instead > > of comparing fields?
The equals() method fails, because the parameter "transient_lastDdlTime" is sometimes off by one. Otherwise, the two objects are entirely equal. I think the db name, table name, and list of values also ensures equality. > On 2011-06-27 22:47:07, Paul Yang wrote: > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java, > > lines 183-194 > > <https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line183> > > > > origCols.equals(oldCols)? Fixed > On 2011-06-27 22:47:07, Paul Yang wrote: > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java, > > lines 159-161 > > <https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line159> > > > > Same here The equals() method also fails here, even though the tables are logically equal. In the case above, "tbl" does not have a PrincipalPrivilegeSet. "oldTable" has a PrincipalPrivilegeSet, but all of it's fields are set to null. This discrepancy comes from how we get the tables, but I think they should still be considered equal. - Sohan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/#review920 ----------------------------------------------------------- On 2011-06-21 20:25:04, Sohan Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/853/ > ----------------------------------------------------------- > > (Updated 2011-06-21 20:25:04) > > > Review request for hive and Paul Yang. > > > Summary > ------- > > HIVE-2038 introduced the MetaStoreEventListener abstract class that defines > actions to be performed after particular events on a metastore. Improve upon > that class by adding events to be performed on "alter table" and "alter > partition" actions. Also, update the hive metastore to call the appropriate > functions of the listeners when the events happen. > > > This addresses bug HIVE-2194. > https://issues.apache.org/jira/browse/HIVE-2194 > > > Diffs > ----- > > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 1138144 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1138144 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java > 1138144 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1138144 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java > PRE-CREATION > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java > PRE-CREATION > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java > 1138144 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > 1138144 > > Diff: https://reviews.apache.org/r/853/diff > > > Testing > ------- > > Added test cases to TestMetaStoreEventListener. > > > Thanks, > > Sohan > >
