----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/973/ -----------------------------------------------------------
Review request for hive, Ashutosh Chauhan, Ning Zhang, and Amareshwari Sriramadasu. Summary ------- * Removed alter database code from previous patch. * Updated create database to gracefully fail if database dir cannot be created (very close to Devaraj's patch) This addresses bug HIVE-1537. https://issues.apache.org/jira/browse/HIVE-1537 Diffs ----- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1140495 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1140495 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 1140495 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1140495 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1140495 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1140495 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1140495 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 1140495 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1140495 trunk/ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1140495 trunk/ql/src/test/queries/clientpositive/database_location.q PRE-CREATION trunk/ql/src/test/results/clientpositive/database_location.q.out PRE-CREATION Diff: https://reviews.apache.org/r/973/diff Testing ------- Updated testDatabaseLocation() in TestHiveMetaStore() to test for negative case. Ran entire unit test and it went through fine for me. Thanks, Thiruvel Thanks, Thiruvel