----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/926/#review925 -----------------------------------------------------------
trunk/ql/src/test/queries/clientnegative/insert_into3.q <https://reviews.apache.org/r/926/#comment1988> Isn't it supposed to succeed instead of failing? What we need is a test that the lock is on partition level. trunk/ql/src/test/queries/clientpositive/insert_into6.q <https://reviews.apache.org/r/926/#comment1989> we need to add a test for dynamic partitioning that the partitions are not empty when you insert into. Also, some partitions inserted is empty and some are not. - Siying On 2011-06-16 15:53:03, Franklin Hu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/926/ > ----------------------------------------------------------- > > (Updated 2011-06-16 15:53:03) > > > Review request for hive. > > > Summary > ------- > > New feature to allow INSERT INTO a table or partition > > > This addresses bug HIVE-306. > https://issues.apache.org/jira/browse/HIVE-306 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1133562 > trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION > trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/926/diff > > > Testing > ------- > > > Thanks, > > Franklin > >
