[
https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054513#comment-13054513
]
jirapos...@reviews.apache.org commented on HIVE-2236:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/948/#review904
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/948/#comment1947>
why do you need to pull this var out of the code block?
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/948/#comment1948>
can you not store the MapRedStatsList in DriverContext?
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/948/#comment1949>
format the code here
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/948/#comment1959>
how do you know the hadoop support this counter
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/948/#comment1960>
are u going to print this info if this job failed?
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/948/#comment1958>
remove 'ms'
- Yongqiang
On 2011-06-23 07:41:33, Siying Dong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/948/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-23 07:41:33)
bq.
bq.
bq. Review request for hive, Yongqiang He, Ning Zhang, and namit jain.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In hive CLI, print out CPU msec from Hadoop MapReduce coutners.
bq.
bq.
bq. This addresses bug HIVE-2236.
bq. https://issues.apache.org/jira/browse/HIVE-2236
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java
PRE-CREATION
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1138748
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
1138748
bq.
bq. Diff: https://reviews.apache.org/r/948/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. run the updated codes against real clusters and make sure it printing is
correct.
bq.
bq.
bq. Thanks,
bq.
bq. Siying
bq.
bq.
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it
> out to Hive CLI when executing a job will help users to know more about their
> jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
