----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/948/#review904 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/948/#comment1947> why do you need to pull this var out of the code block? trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/948/#comment1948> can you not store the MapRedStatsList in DriverContext? trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/948/#comment1949> format the code here trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java <https://reviews.apache.org/r/948/#comment1959> how do you know the hadoop support this counter trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java <https://reviews.apache.org/r/948/#comment1960> are u going to print this info if this job failed? trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/948/#comment1958> remove 'ms' - Yongqiang On 2011-06-23 07:41:33, Siying Dong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/948/ > ----------------------------------------------------------- > > (Updated 2011-06-23 07:41:33) > > > Review request for hive, Yongqiang He, Ning Zhang, and namit jain. > > > Summary > ------- > > In hive CLI, print out CPU msec from Hadoop MapReduce coutners. > > > This addresses bug HIVE-2236. > https://issues.apache.org/jira/browse/HIVE-2236 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1138748 > trunk/ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1138748 > trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java PRE-CREATION > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1138748 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java > 1138748 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1138748 > trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java > 1138748 > > Diff: https://reviews.apache.org/r/948/diff > > > Testing > ------- > > run the updated codes against real clusters and make sure it printing is > correct. > > > Thanks, > > Siying > >
