[
https://issues.apache.org/jira/browse/HIVE-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052334#comment-13052334
]
jirapos...@reviews.apache.org commented on HIVE-872:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/889/
-----------------------------------------------------------
(Updated 2011-06-21 02:50:57.581129)
Review request for hive and John Sichi.
Changes
-------
Update test cases udf_coalesce.q and union2.q to check that type-widening is
not applied incorrectly, use getCommonClassForComparison instead of
getCommonClass to compute type widening on union operator (fixing
explode_null.q)
Summary
-------
Added a rule to the lexical grammar to allow BIGINT constants ending with 'L',
and a clause to the TypeCheckProcFactory to ensure it gets interpreted properly.
This addresses bug HIVE-872.
https://issues.apache.org/jira/browse/HIVE-872
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 2462517
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ec816e9
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java
f46c16c
ql/src/test/queries/clientnegative/udf_coalesce.q 6d8da79
ql/src/test/queries/clientnegative/union2.q 403d19d
ql/src/test/queries/clientpositive/type_widening.q PRE-CREATION
ql/src/test/results/clientnegative/udf_coalesce.q.out a4c3cab
ql/src/test/results/clientnegative/union2.q.out 16cfe03
ql/src/test/results/clientpositive/type_widening.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/889/diff
Testing
-------
TestCliDriver passes, previous behaviour was to accept bigint constants
specified without 'L', which is also preserved, so adding additional tests for
this case seems unnecessary.
Thanks,
Syed
> Allow type widening on COALESCE/UNION ALL
> -----------------------------------------
>
> Key: HIVE-872
> URL: https://issues.apache.org/jira/browse/HIVE-872
> Project: Hive
> Issue Type: New Feature
> Reporter: Zheng Shao
> Assignee: Syed S. Albiz
> Attachments: HIVE-872.1.patch, HIVE-872.6.patch, HIVE-872.7.patch
>
>
> Original request: We should allow "0L" to be interpreted as a bigint constant.
> Instead of this, we have decided that the usecases for this do not merit
> modifications to the ql. Instead we enable type widening on the UDF COALESCE
> and on the UNION ALL operator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
