[
https://issues.apache.org/jira/browse/HIVE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050030#comment-13050030
]
jirapos...@reviews.apache.org commented on HIVE-2218:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/898/#review846
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java
<https://reviews.apache.org/r/898/#comment1839>
If we change accept(), we need to remove + File.separator here.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java
<https://reviews.apache.org/r/898/#comment1837>
I think it would be better to use path.getParent().toString() instead of
doing string manipulation.
- Ning
On 2011-06-15 20:24:15, Yongqiang He wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/898/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-15 20:24:15)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. speedup addInputPaths
bq.
bq.
bq. This addresses bug HIVE-2218.
bq. https://issues.apache.org/jira/browse/HIVE-2218
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1135335
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java
1135335
bq.
bq. Diff: https://reviews.apache.org/r/898/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. yes.
bq.
bq.
bq. Thanks,
bq.
bq. Yongqiang
bq.
bq.
> speedup addInputPaths
> ---------------------
>
> Key: HIVE-2218
> URL: https://issues.apache.org/jira/browse/HIVE-2218
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2218.1.patch, HIVE-2218.2.patch
>
>
> Speedup the addInputPaths for combined symlink inputformat, and added some
> other micro optimizations which also work for normal cases.
> This can help reducing the start time of one query from 5 hours to less than
> 20 mins.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
