----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/898/#review846 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java <https://reviews.apache.org/r/898/#comment1839> If we change accept(), we need to remove + File.separator here. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java <https://reviews.apache.org/r/898/#comment1837> I think it would be better to use path.getParent().toString() instead of doing string manipulation. - Ning On 2011-06-15 20:24:15, Yongqiang He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/898/ > ----------------------------------------------------------- > > (Updated 2011-06-15 20:24:15) > > > Review request for hive. > > > Summary > ------- > > speedup addInputPaths > > > This addresses bug HIVE-2218. > https://issues.apache.org/jira/browse/HIVE-2218 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1135335 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java > 1135335 > > Diff: https://reviews.apache.org/r/898/diff > > > Testing > ------- > > yes. > > > Thanks, > > Yongqiang > >
