> On 2011-05-14 07:39:31, Ning Zhang wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, > > line 1194 > > <https://reviews.apache.org/r/626/diff/3/?file=18468#file18468line1194> > > > > We shouldn't check interrupt here since ObjectStore should be run at > > the metastore server side (if Hive is running non-local mode for > > metastore). So ^C on CLI won't be detected here. Instead we should check it > > in HiveMetaStoreClient.java. > > > > Since interrupting JDO is quite complicated, I suggest removing the > > interrupt handling for JDO completely in this JIRA and file a separate JIRA > > for that.
ok, reverting ObjectStore changes. > On 2011-05-14 07:39:31, Ning Zhang wrote: > > trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java, line 326 > > <https://reviews.apache.org/r/626/diff/2-3/?file=17625#file17625line326> > > > > Is this comment correct? Nope, comment fixed. - georgedj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/626/#review670 ----------------------------------------------------------- On 2011-05-10 21:55:56, georgedj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/626/ > ----------------------------------------------------------- > > (Updated 2011-05-10 21:55:56) > > > Review request for hive. > > > Summary > ------- > > Fixed by adding INT signal hander that interrupts the CLI thread. The CLI > thread gets InterruptedException and it stops the current command. > > > This addresses bug HIVE-243. > https://issues.apache.org/jira/browse/HIVE-243 > > > Diffs > ----- > > trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 > > trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java > PRE-CREATION > trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java > PRE-CREATION > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1100312 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java > 1100312 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 > > Diff: https://reviews.apache.org/r/626/diff > > > Testing > ------- > > Manual test Ctrl+C on bunch of command (show tables, select, etc) > Tested interrupting the command on large data set in different stages of the > processing (JDO, MapReduce, building the input summary). > example queries: > explain select count(*) from xyz where ds = '2011-02-01'; > select count(*) from xyz where ds = '2011-02-01'; > > > Thanks, > > georgedj > >
