[
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033481#comment-13033481
]
jirapos...@reviews.apache.org commented on HIVE-243:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review670
-----------------------------------------------------------
trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/626/#comment1337>
Is this comment correct?
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java
<https://reviews.apache.org/r/626/#comment1336>
typo: interrup -> interrupt.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/626/#comment1335>
We shouldn't check interrupt here since ObjectStore should be run at the
metastore server side (if Hive is running non-local mode for metastore). So ^C
on CLI won't be detected here. Instead we should check it in
HiveMetaStoreClient.java.
Since interrupting JDO is quite complicated, I suggest removing the
interrupt handling for JDO completely in this JIRA and file a separate JIRA for
that.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/626/#comment1334>
typo: interrup -> interrupt
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/626/#comment1338>
why these are removed?
- Ning
On 2011-05-10 21:55:56, georgedj wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/626/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-10 21:55:56)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fixed by adding INT signal hander that interrupts the CLI thread. The CLI
thread gets InterruptedException and it stops the current command.
bq.
bq.
bq. This addresses bug HIVE-243.
bq. https://issues.apache.org/jira/browse/HIVE-243
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312
bq.
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java
PRE-CREATION
bq.
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java
PRE-CREATION
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
1100312
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
1100312
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312
bq.
bq. Diff: https://reviews.apache.org/r/626/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Manual test Ctrl+C on bunch of command (show tables, select, etc)
bq. Tested interrupting the command on large data set in different stages of
the processing (JDO, MapReduce, building the input summary).
bq. example queries:
bq. explain select count(*) from xyz where ds = '2011-02-01';
bq. select count(*) from xyz where ds = '2011-02-01';
bq.
bq.
bq. Thanks,
bq.
bq. georgedj
bq.
bq.
> ^C breaks out of running query, but not whole CLI
> -------------------------------------------------
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
> Issue Type: Wish
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it.
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was
> some control character to break out of a query without breaking out of the
> CLI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
