----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/700/ -----------------------------------------------------------
(Updated 2011-05-11 13:14:36.754720) Review request for hive. Changes ------- Updated the patch to do prefix matching and added a testcase. Summary ------- Attached patch generates a single M/R job for multi group by query with non-null common group by key set. Added configuration hive.multigroupby.singlemr to turn on and off the optimization. This addresses bug HIVE-2056. https://issues.apache.org/jira/browse/HIVE-2056 Diffs (updated) ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1100910 trunk/conf/hive-default.xml 1100910 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1100910 trunk/ql/src/test/queries/clientpositive/groupby10.q 1100910 trunk/ql/src/test/queries/clientpositive/groupby8.q 1100910 trunk/ql/src/test/queries/clientpositive/groupby8_noskew.q 1100910 trunk/ql/src/test/queries/clientpositive/groupby9.q 1100910 trunk/ql/src/test/queries/clientpositive/multigroupby_singlemr.q PRE-CREATION trunk/ql/src/test/results/clientpositive/groupby10.q.out 1100910 trunk/ql/src/test/results/clientpositive/groupby8.q.out 1100910 trunk/ql/src/test/results/clientpositive/groupby9.q.out 1100910 trunk/ql/src/test/results/clientpositive/multigroupby_singlemr.q.out PRE-CREATION Diff: https://reviews.apache.org/r/700/diff Testing (updated) ------- Updated jira with performance tests. All unit tests passed with the patch Thanks, Amareshwari