[
https://issues.apache.org/jira/browse/HIVE-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031685#comment-13031685
]
jirapos...@reviews.apache.org commented on HIVE-2056:
-----------------------------------------------------
bq. On 2011-05-09 17:07:16, namit jain wrote:
bq. > Change hive-default.xml with the new parameter.
bq. > Add the new parameter in the name of the jira.
Done
bq. On 2011-05-09 17:07:16, namit jain wrote:
bq. > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java,
line 5518
bq. > <https://reviews.apache.org/r/700/diff/1/?file=18439#file18439line5518>
bq. >
bq. > Add a comment - this optimization is not enabled
bq. > if one of the sub-queries does not involve a
bq. > aggregation
Done
bq. On 2011-05-09 17:07:16, namit jain wrote:
bq. > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java,
line 5524
bq. > <https://reviews.apache.org/r/700/diff/1/?file=18439#file18439line5524>
bq. >
bq. > The code is not preforming a prefix match.
bq. > I mean,
bq. >
bq. > if the query is:
bq. >
bq. > from T
bq. > insert overwrite T1 select ... group by c1
bq. > insert overwrite T1 select ... group by c2, c1
bq. >
bq. >
bq. > c1 will still be returned.
bq. >
bq. > Is that desirable ?
bq. >
bq. > I dont think this will work - can you add a testcase
bq. > for this - I mean, with a explain which shows that
bq. > the parameter does not make a difference
bq. >
Agreed. I missed this.
Updated the patch with prefix matching
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/700/#review651
-----------------------------------------------------------
On 2011-05-11 13:14:36, Amareshwari Sriramadasu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/700/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-11 13:14:36)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached patch generates a single M/R job for multi group by query with
non-null common group by key set. Added configuration
hive.multigroupby.singlemr to turn on and off the optimization.
bq.
bq.
bq. This addresses bug HIVE-2056.
bq. https://issues.apache.org/jira/browse/HIVE-2056
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1100910
bq. trunk/conf/hive-default.xml 1100910
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1100910
bq. trunk/ql/src/test/queries/clientpositive/groupby10.q 1100910
bq. trunk/ql/src/test/queries/clientpositive/groupby8.q 1100910
bq. trunk/ql/src/test/queries/clientpositive/groupby8_noskew.q 1100910
bq. trunk/ql/src/test/queries/clientpositive/groupby9.q 1100910
bq. trunk/ql/src/test/queries/clientpositive/multigroupby_singlemr.q
PRE-CREATION
bq. trunk/ql/src/test/results/clientpositive/groupby10.q.out 1100910
bq. trunk/ql/src/test/results/clientpositive/groupby8.q.out 1100910
bq. trunk/ql/src/test/results/clientpositive/groupby9.q.out 1100910
bq. trunk/ql/src/test/results/clientpositive/multigroupby_singlemr.q.out
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/700/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jira with performance tests.
bq.
bq. All unit tests passed with the patch
bq.
bq.
bq. Thanks,
bq.
bq. Amareshwari
bq.
bq.
> Generate single MR job for multi groupby query.
> -----------------------------------------------
>
> Key: HIVE-2056
> URL: https://issues.apache.org/jira/browse/HIVE-2056
> Project: Hive
> Issue Type: Improvement
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.8.0
>
> Attachments: patch-2056-1.txt, patch-2056-2.txt, patch-2056.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
