[
https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030165#comment-13030165
]
jirapos...@reviews.apache.org commented on HIVE-1731:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/699/
-----------------------------------------------------------
Review request for hive.
Summary
-------
Review by jvs.
This addresses bug HIVE-1731.
https://issues.apache.org/jira/browse/HIVE-1731
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java a68a5c3
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java d738c48
ql/src/test/results/clientnegative/alter_view_failure6.q.out b9447fa
ql/src/test/results/clientnegative/ambiguous_col.q.out 9838e27
ql/src/test/results/clientnegative/archive1.q.out 0927686
ql/src/test/results/clientnegative/bad_sample_clause.q.out 9ddb18f
ql/src/test/results/clientnegative/clusterbydistributeby.q.out 9151ff2
ql/src/test/results/clientnegative/clusterbyorderby.q.out 5a50355
ql/src/test/results/clientnegative/clusterbysortby.q.out d79c319
ql/src/test/results/clientnegative/clustern3.q.out 37c103f
ql/src/test/results/clientnegative/clustern4.q.out fcfa605
ql/src/test/results/clientnegative/column_rename3.q.out bdca52e
ql/src/test/results/clientnegative/create_view_failure3.q.out 7f3a710
ql/src/test/results/clientnegative/drop_function_failure.q.out 0629c37
ql/src/test/results/clientnegative/drop_index_failure.q.out c91afac
ql/src/test/results/clientnegative/drop_partition_failure.q.out 97b4839
ql/src/test/results/clientnegative/dyn_part2.q.out 636096d
ql/src/test/results/clientnegative/exim_00_unsupported_schema.q.out 744f518
ql/src/test/results/clientnegative/fileformat_void_input.q.out ce62d79
ql/src/test/results/clientnegative/groupby2_map_skew_multi_distinct.q.out
494db44
ql/src/test/results/clientnegative/groupby2_multi_distinct.q.out e0a1dee
ql/src/test/results/clientnegative/groupby3_map_skew_multi_distinct.q.out
5702d4f
ql/src/test/results/clientnegative/groupby3_multi_distinct.q.out 5702d4f
ql/src/test/results/clientnegative/groupby_key.q.out 8c30cc4
ql/src/test/results/clientnegative/input1.q.out f4e830e
ql/src/test/results/clientnegative/input2.q.out a8ba9c5
ql/src/test/results/clientnegative/input_part0_neg.q.out 566b5bf
ql/src/test/results/clientnegative/invalid_create_tbl2.q.out ae81881
ql/src/test/results/clientnegative/invalid_select_expression.q.out 69ec9ef
ql/src/test/results/clientnegative/invalid_tbl_name.q.out aff52fa
ql/src/test/results/clientnegative/invalidate_view1.q.out be64a4d
ql/src/test/results/clientnegative/join2.q.out 43565ee
ql/src/test/results/clientnegative/joinneg.q.out b1d22f8
ql/src/test/results/clientnegative/lateral_view_join.q.out b5a8c3b
ql/src/test/results/clientnegative/load_part_nospec.q.out 6886e98
ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 7b083e3
ql/src/test/results/clientnegative/nopart_insert.q.out 46e724f
ql/src/test/results/clientnegative/nopart_load.q.out 84868e4
ql/src/test/results/clientnegative/notable_alias3.q.out 15181a0
ql/src/test/results/clientnegative/orderbysortby.q.out 28c3dd6
ql/src/test/results/clientnegative/regex_col_1.q.out 224c271
ql/src/test/results/clientnegative/regex_col_2.q.out 5449148
ql/src/test/results/clientnegative/regex_col_groupby.q.out db7c4a8
ql/src/test/results/clientnegative/sample.q.out 1363980
ql/src/test/results/clientnegative/select_udtf_alias.q.out f468719
ql/src/test/results/clientnegative/semijoin1.q.out 83235d0
ql/src/test/results/clientnegative/semijoin2.q.out b846e8a
ql/src/test/results/clientnegative/semijoin3.q.out 2481fc6
ql/src/test/results/clientnegative/semijoin4.q.out 2c2a5df
ql/src/test/results/clientnegative/show_tables_bad1.q.out 7a81c06
ql/src/test/results/clientnegative/show_tables_bad2.q.out 7a81c06
ql/src/test/results/clientnegative/smb_bucketmapjoin.q.out 5f0e654
ql/src/test/results/clientnegative/strict_orderby.q.out fe8fd62
ql/src/test/results/clientnegative/strict_pruning.q.out 3f6ce49
ql/src/test/results/clientnegative/subq_insert.q.out da8d18a
ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out a9fc662
ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 25459e1
ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 69ea973
ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 356f91d
ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd13bda
ql/src/test/results/clientnegative/udf_coalesce.q.out 44b5de9
ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out ef4e67f
ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out 1ca50f7
ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 42b24eb
ql/src/test/results/clientnegative/udf_field_wrong_type.q.out 2c6a48e
ql/src/test/results/clientnegative/udf_if_not_bool.q.out d7ae204
ql/src/test/results/clientnegative/udf_if_wrong_args_len.q.out 8862493
ql/src/test/results/clientnegative/udf_in.q.out 9dd7ee5
ql/src/test/results/clientnegative/udf_instr_wrong_args_len.q.out 5465ebf
ql/src/test/results/clientnegative/udf_instr_wrong_type.q.out c4854a6
ql/src/test/results/clientnegative/udf_locate_wrong_args_len.q.out 6b5ad6f
ql/src/test/results/clientnegative/udf_locate_wrong_type.q.out 3506901
ql/src/test/results/clientnegative/udf_size_wrong_args_len.q.out edb9662
ql/src/test/results/clientnegative/udf_size_wrong_type.q.out ea41485
ql/src/test/results/clientnegative/udf_when_type_wrong.q.out ced2310
ql/src/test/results/clientnegative/udf_when_type_wrong2.q.out 0911660
ql/src/test/results/clientnegative/udf_when_type_wrong3.q.out 4836e89
ql/src/test/results/clientnegative/union.q.out 2f670f9
Diff: https://reviews.apache.org/r/699/diff
Testing
-------
Thanks,
John
> Improve miscellaneous error messages
> ------------------------------------
>
> Key: HIVE-1731
> URL: https://issues.apache.org/jira/browse/HIVE-1731
> Project: Hive
> Issue Type: Improvement
> Components: Diagnosability, Query Processor
> Reporter: John Sichi
> Assignee: Syed S. Albiz
> Attachments: 0001-Fixed-parse-error-line-number-issue.patch,
> 0001-Fixed-parse-error-line-number-issue.patch,
> 0002-update-test-cases-with-error-string-results.patch, HIVE-1731.1.patch,
> HIVE-1731.2.patch, HIVE-1731.3.patch
>
>
> This is a place for accumulating error message improvements so that we can
> update a bunch in batch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
