[
https://issues.apache.org/jira/browse/HIVE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023056#comment-13023056
]
jirapos...@reviews.apache.org commented on HIVE-2123:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/646/#review527
-----------------------------------------------------------
trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/646/#comment1091>
There's a try/catch block here, so why not do this the Java way and throw
an exception instead of returning a status code?
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/646/#comment1092>
Can you replace this with a DriverException class?
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/646/#comment1093>
spacing
- Carl
On 2011-04-22 00:11:43, Siying Dong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/646/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-22 00:11:43)
bq.
bq.
bq. Review request for hive, Yongqiang He and namit jain.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. now when CommandNeedRetryException is thrown, locks are not released. Not
sure whether it will cause problem, since the same locks will be acquired when
retrying it. It is anyway something we need to fix. Also we can do some little
code cleaning up to make future mistakes less likely.
bq.
bq.
bq. This addresses bug HIVE-2123.
bq. https://issues.apache.org/jira/browse/HIVE-2123
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095838
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095838
bq.
bq. Diff: https://reviews.apache.org/r/646/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Siying
bq.
bq.
> CommandNeedRetryException needs release locks
> ---------------------------------------------
>
> Key: HIVE-2123
> URL: https://issues.apache.org/jira/browse/HIVE-2123
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2123.1.patch
>
>
> now when CommandNeedRetryException is thrown, locks are not released. Not
> sure whether it will cause problem, since the same locks will be acquired
> when retrying it. It is anyway something we need to fix. Also we can do some
> little code cleaning up to make future mistakes less likely.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
