----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/646/#review527 -----------------------------------------------------------
trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java <https://reviews.apache.org/r/646/#comment1091> There's a try/catch block here, so why not do this the Java way and throw an exception instead of returning a status code? trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/646/#comment1092> Can you replace this with a DriverException class? trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/646/#comment1093> spacing - Carl On 2011-04-22 00:11:43, Siying Dong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/646/ > ----------------------------------------------------------- > > (Updated 2011-04-22 00:11:43) > > > Review request for hive, Yongqiang He and namit jain. > > > Summary > ------- > > now when CommandNeedRetryException is thrown, locks are not released. Not > sure whether it will cause problem, since the same locks will be acquired > when retrying it. It is anyway something we need to fix. Also we can do some > little code cleaning up to make future mistakes less likely. > > > This addresses bug HIVE-2123. > https://issues.apache.org/jira/browse/HIVE-2123 > > > Diffs > ----- > > trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095838 > trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095838 > > Diff: https://reviews.apache.org/r/646/diff > > > Testing > ------- > > > Thanks, > > Siying > >
