----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/558/#review492 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java <https://reviews.apache.org/r/558/#comment998> Still need to change hive.index.compact.file to hive.index.blockfilter.file , but hopefully bitmap gets committed soon. ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java <https://reviews.apache.org/r/558/#comment997> I'm not sure the way I'm doing it currently will work with partitions. I don't take them into account when generating the index query. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java <https://reviews.apache.org/r/558/#comment1000> see later comment about why this abort needs to be skipped for anything to run. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java <https://reviews.apache.org/r/558/#comment999> This doesn't seem to work (it always returns false here). This checks whether the partitions equal each other, which I don't think can happen since they're on different tables. What information in a partition do I need to be checking? ql/src/test/queries/clientpositive/index_auto_multiple.q <https://reviews.apache.org/r/558/#comment995> Is there a multiple column table? Or, what's the best way to create a multi-column table and populate it with data? I can't figure out a good way to query the value column, so the src table seems less than ideal. ql/src/test/queries/clientpositive/index_auto_unused.q <https://reviews.apache.org/r/558/#comment996> How do unbuilt partitions work? I didn't see any way to delay the building, so I don't know how to have an index with unbuilt partitions. - Russell On 2011-04-16 06:04:26, Russell Melick wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/558/ > ----------------------------------------------------------- > > (Updated 2011-04-16 06:04:26) > > > Review request for hive. > > > Summary > ------- > > Review request for HIVE-1644.12.patch > > > This addresses bug HIVE-1644. > https://issues.apache.org/jira/browse/HIVE-1644 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a21f589 > conf/hive-default.xml c42197f > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 14015d0 > ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 6437385 > ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java c02d90b > ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java > dd0186d > ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexHandler.java 411b78f > ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java > 1f01446 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 50db44c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java > 6162676 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/IndexWhereResolver.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java > 0ae9fa2 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcCtx.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 937a7b3 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f0aca84 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 73391e9 > ql/src/test/queries/clientpositive/index_auto.q PRE-CREATION > ql/src/test/queries/clientpositive/index_auto_file_format.q PRE-CREATION > ql/src/test/queries/clientpositive/index_auto_multiple.q PRE-CREATION > ql/src/test/queries/clientpositive/index_auto_partitioned.q PRE-CREATION > ql/src/test/queries/clientpositive/index_auto_unused.q PRE-CREATION > ql/src/test/results/clientpositive/index_auto.q.out PRE-CREATION > ql/src/test/results/clientpositive/index_auto_file_format.q.out > PRE-CREATION > ql/src/test/results/clientpositive/index_auto_multiple.q.out PRE-CREATION > ql/src/test/results/clientpositive/index_auto_partitioned.q.out > PRE-CREATION > ql/src/test/results/clientpositive/index_auto_unused.q.out PRE-CREATION > ql/src/test/results/clientpositive/index_opt_where.q.out PRE-CREATION > ql/src/test/results/clientpositive/index_opt_where_partitioned.q.out > PRE-CREATION > ql/src/test/results/clientpositive/index_opt_where_simple.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/558/diff > > > Testing > ------- > > > Thanks, > > Russell > >
