[ 
https://issues.apache.org/jira/browse/HIVE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020153#comment-13020153
 ] 

jirapos...@reviews.apache.org commented on HIVE-2070:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/603/
-----------------------------------------------------------

Review request for hive.


Summary
-------

This changes the grantTimestamp that gets outputted in a SHOW GRANT from a Unix 
timestamp to a human-readable date.


This addresses bug HIVE-2070.
    https://issues.apache.org/jira/browse/HIVE-2070


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9d8919c 

Diff: https://reviews.apache.org/r/603/diff


Testing
-------

Manual.  The field is normally not excluded from diffs, because it will vary 
from test run to test run, so it didn't seem prudent to try to write an 
automated test for this.


Thanks,

Jonathan



> SHOW GRANT grantTime field should be a human-readable timestamp
> ---------------------------------------------------------------
>
>                 Key: HIVE-2070
>                 URL: https://issues.apache.org/jira/browse/HIVE-2070
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor, Security
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HIVE-2070.1.patch
>
>
> Unix timestamps are not super useful when trying to interpret metadata
> hive> show grant user foo on table bar;
> database      default 
> table bar     
> principalName foo     
> principalType USER    
> privilege     Select  
> grantTime     1300828549      
> grantor       natty   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to