----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/551/#review462 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java <https://reviews.apache.org/r/551/#comment886> Doesn't look like this list is referenced anywhere. Please remove. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g <https://reviews.apache.org/r/551/#comment887> The message should be "restrict or cascade clause", not "if force clause". You may also want to consider splitting this into two different rules so that we can output either "restrict clause" or "cascade clause". trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java <https://reviews.apache.org/r/551/#comment888> Please replace instances of "force" with "cascade" in this file and everywhere else so that the code is aligned with the HQL grammar. trunk/ql/src/test/queries/clientpositive/database.q <https://reviews.apache.org/r/551/#comment889> Please add a brief comment for each block explaining what you are testing (see earlier examples in this same test). trunk/ql/src/test/queries/clientpositive/database.q <https://reviews.apache.org/r/551/#comment890> Please add a negative test case that attempts to drop a non-empty DB with the RESTRICT clause set. You can probably copy the HQL code in database_drop_not_empty.q - Carl On 2011-04-14 00:17:09, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/551/ > ----------------------------------------------------------- > > (Updated 2011-04-14 00:17:09) > > > Review request for hive. > > > Summary > ------- > > https://issues.apache.org/jira/secure/attachment/12476199/HIVE-2090.5.patch > > > This addresses bug HIVE-2090. > https://issues.apache.org/jira/browse/HIVE-2090 > > > Diffs > ----- > > trunk/metastore/if/hive_metastore.thrift 1091617 > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617 > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617 > > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp > 1091617 > > trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > 1091617 > > trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php > 1091617 > > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote > 1091617 > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py > 1091617 > trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1091617 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 1091617 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 1091617 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1091617 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617 > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java > 1091617 > trunk/ql/src/test/queries/clientpositive/database.q 1091617 > trunk/ql/src/test/results/clientpositive/database.q.out 1091617 > > Diff: https://reviews.apache.org/r/551/diff > > > Testing > ------- > > > Thanks, > > Carl > >
