[ 
https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019698#comment-13019698
 ] 

jirapos...@reviews.apache.org commented on HIVE-1943:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/586/#review459
-----------------------------------------------------------

Ship it!


+1
Please upload the patch to jira.

- Amareshwari


On 2011-04-14 00:57:35, Devaraj Das wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/586/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-04-14 00:57:35)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is a patch to handle the issue described in HIVE-1943
bq.  
bq.  
bq.  This addresses bug HIVE-1943.
bq.      https://issues.apache.org/jira/browse/HIVE-1943
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 1091578 
bq.    http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1091578 
bq.    
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 1091578 
bq.    
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
 1091578 
bq.    
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
 1091578 
bq.    
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
 PRE-CREATION 
bq.    
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
 1091578 
bq.    
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
 1091578 
bq.    
http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java
 1091578 
bq.    
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
 1091578 
bq.  
bq.  Diff: https://reviews.apache.org/r/586/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Unit tests added.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Devaraj
bq.  
bq.



> Metastore operations (like drop_partition) could be improved in terms of 
> maintaining consistency of metadata and data
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-1943
>                 URL: https://issues.apache.org/jira/browse/HIVE-1943
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>
> Currently, metastore operations with associated hdfs operations like 
> drop_partition doesn't do a rollback if the hdfs operation fails. The 
> metastore first updates the metadata, and then tries to do hdfs operation. If 
> the hdfs operation fails for any reason, the data on the hdfs will be 
> orphaned. We should improve the situation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to